this post was submitted on 24 May 2024
310 points (98.4% liked)

Programmer Humor

32415 readers
276 users here now

Post funny things about programming here! (Or just rant about your favourite programming language.)

Rules:

founded 5 years ago
MODERATORS
310
submitted 5 months ago* (last edited 5 months ago) by [email protected] to c/[email protected]
 
you are viewing a single comment's thread
view the rest of the comments
[–] [email protected] 56 points 5 months ago (6 children)

There's a string stating that the code should not be passed or the employee will be fired. I'd assume this was a test to see if an employee meant to be doing code review was actually doing them. Spoiler, they were not, as OP said they found this in production code.

[–] [email protected] 13 points 5 months ago (5 children)

I'd go a step further and I suspect it's a peppering string (i.e. fixed string you add to hashes to defeat rainbow tables). I'd really hope it isn't as you mentioned because gosh that sounds like a toxic workplace if someone is just leaving landmines around purely to get someone fired.

[–] [email protected] 19 points 5 months ago (1 children)

More like, you know damn well that Jim keeps passing code reviews without reading a line in them, he's been talked to, still does it, and you need something actionable to prove it so that you can get someone's ass in his chair who does their job.

[–] [email protected] 12 points 5 months ago

From the stories I've heard from corporate software employees, this does sound like exactly the kind of thing you gotta do to show some manager the guy is buddy-buddy with that they're actually not doing their job. And even then they didn't listen.

load more comments (3 replies)
load more comments (3 replies)